Skip to content

test(radio): skip Safari on legacy tab key tests #28387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2023
Merged

test(radio): skip Safari on legacy tab key tests #28387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eccfba
fix(radio): tabbing
thetaPC Oct 19, 2023
d99449a
fix(radio): skip Safari
thetaPC Oct 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions core/src/components/radio/test/legacy/a11y/radio.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ import { configs, test } from '@utils/test/playwright';
*/
configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) => {
test.describe(title('radio: a11y'), () => {
// TODO(FW-5218)
test.fixme('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
test.beforeEach(async ({ page, skip }) => {
skip.browser('webkit', 'Tabbing is flaky in Safari');
await page.goto(`/src/components/radio/test/legacy/a11y`, config);

});
test('tabbing should switch between radio groups', async ({ page, pageUtils }) => {
const firstGroupRadios = page.locator('#first-group ion-radio');
const secondGroupRadios = page.locator('#second-group ion-radio');

Expand All @@ -22,10 +23,7 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>
await pageUtils.pressKeys('shift+Tab');
await expect(firstGroupRadios.nth(0)).toBeFocused();
});
// TODO(FW-5218)
test.fixme('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
await page.goto(`/src/components/radio/test/legacy/a11y`, config);

test('using arrow keys should move between enabled radios within group', async ({ page, pageUtils }) => {
const firstGroupRadios = page.locator('#first-group ion-radio');

await pageUtils.pressKeys('Tab');
Expand Down