feat(range): adding custom styling for ionic theme #29979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-pedrolourenco
changed the title
| --bar-background: #{globals.$ion-primitives-neutral-100}; | ||
| --bar-background-active: #{globals.ion-color(primary, base)}; | ||
| --bar-border-radius: #{globals.$ion-border-radius-400}; | ||
| --height: 42px; |
There was a problem hiding this comment.
I think this should use scale-1000 to match the knob area and then we can adjust the pin in the other PR to reach the 68px total height
Suggested change
| --height: 42px; | |
| --height: #{globals.$ion-scale-1000}; |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
No ionic theme custom implementation existed for the ion-range component.
What is the new behavior?
Does this introduce a breaking change?
Other information