Skip to content

chore(deps): update outsystems-design-tokens dependency #30198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Feb 20, 2025
Merged

chore(deps): update outsystems-design-tokens dependency #30198

merged 14 commits into from
Feb 20, 2025

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Feb 19, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Update to outsystems-design-tokens 1.2.0.
  • Generate variables and utility-classes with updated tokens values.
  • Updated screenshots, after UX/UI review:
    • updated ionic color tokens on links.
    • updated segment label size token to sm.

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added package: core @ionic/core package dependencies Pull requests that update a dependency file labels Feb 19, 2025
@vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:08pm

@BenOsodrac BenOsodrac marked this pull request as ready for review February 19, 2025 17:24
@BenOsodrac BenOsodrac requested a review from a team as a code owner February 19, 2025 17:24
@BenOsodrac BenOsodrac requested review from brandyscarney, joselrio and thetaPC and removed request for brandyscarney and joselrio February 19, 2025 17:24
brandyscarney
brandyscarney reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions on the action size change!

thetaPC
thetaPC requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same requests as Brandy.

@BenOsodrac BenOsodrac requested a review from thetaPC February 20, 2025 12:08
@ionic-team ionic-team deleted a comment from JonathanSlama Feb 20, 2025
brandyscarney
brandyscarney approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

thetaPC
thetaPC approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit f6ce023 into next Feb 20, 2025
47 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11646 branch February 20, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BenOsodrac @brandyscarney @thetaPC @Ionitron