Skip to content

Conversation

@thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Feb 24, 2025

Issue number: internal


What is the current behavior?

Searchbar does not have shapes.

What is the new behavior?

  • Added shapes to ionic theme: round, soft, and rectangular
  • ionic theme defaults to round
  • ios and md theme defaults to undefined
  • Added snapshots

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel
Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 4:13pm

@github-actions github-actions bot added the package: core @ionic/core package label Feb 24, 2025
@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package labels Feb 24, 2025
@thetaPC thetaPC marked this pull request as ready for review February 24, 2025 21:04
@thetaPC thetaPC requested a review from a team as a code owner February 24, 2025 21:04
@thetaPC thetaPC requested review from brandyscarney and christian-bromann and removed request for christian-bromann February 24, 2025 21:04
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thetaPC thetaPC merged commit fc552ad into next Feb 25, 2025
47 checks passed
@thetaPC thetaPC deleted the ROU-11252 branch February 25, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants