feat(button): add spinner sizes for ionic theme #30233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
OS-martacarlos
force-pushed
the
ROU-11613
branch
from
55127c5 to
0d88065
Compare
thetaPC
requested changes
Mar 8, 2025
also update e2e tests spanshots
OS-martacarlos
force-pushed
the
ROU-11613
branch
from
af6c299 to
0865a33
Compare
thetaPC
requested changes
Mar 10, 2025
| import { expect } from '@playwright/test'; | ||
| import { configs, test } from '@utils/test/playwright'; | ||
|
|
||
| configs({ modes: ['ionic-md', 'ionic-ios'] }).forEach(({ config, screenshot, title }) => { |
There was a problem hiding this comment.
Since the functionality doesn't change, we don't need to test for all the modes. I also realize that we don't need to test RTL since functionality doesn't change.
I suggest only testing ionic-md. Make sure to remove the snapshots for ionic-ios and RTL.
Suggested change
| configs({ modes: ['ionic-md', 'ionic-ios'] }).forEach(({ config, screenshot, title }) => { | |
| configs({ modes: ['ionic-md'], directions: ['ltr'] }).forEach(({ config, screenshot, title }) => { |
thetaPC
requested changes
Mar 10, 2025
OS-martacarlos
force-pushed
the
ROU-11613
branch
from
f816a29 to
f5ee753
Compare
OS-martacarlos
force-pushed
the
ROU-11613
branch
2 times, most recently
from
691475f to
8ba6fb2
Compare
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
OS-martacarlos
force-pushed
the
ROU-11613
branch
from
8ba6fb2 to
18312f7
Compare
thetaPC
requested changes
Mar 11, 2025
There was a problem hiding this comment.
The RTL snapshots need to be removed since those aren't being tested.
BenOsodrac
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Spinners inside buttons don't have any specific styling.
What is the new behavior?
According to the design, for the ionic theme, the size of spinners inside buttons need specific values. To accommodate those:
Does this introduce a breaking change?