-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(radio-group): add helper and error text to the ionic theme #30271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0e55445
fix(input): remove --text-color-invalid var
brandyscarney 230abcc
feat(radio-group): add helper and error text to the ionic theme
brandyscarney 6a3efa8
Revert "fix(input): remove --text-color-invalid var"
brandyscarney a0b01de
Merge branch 'next' into FW-6389-radio-group
brandyscarney 6ce549d
refactor(radio-group): fix imports
brandyscarney ba6ce3c
style: linttttt
brandyscarney cf4bdfb
fix(radio-group): use correct margin for top content
brandyscarney a8b8275
Merge branch 'next' into FW-6389-radio-group
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 1 addition & 15 deletions
16
...c/components/radio-group/radio-group.scss → ...nents/radio-group/radio-group.common.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| @use "../../themes/ionic/ionic.globals" as globals; | ||
| @import "./radio-group.common"; | ||
|
|
||
| // Ionic Radio Group Top | ||
| // -------------------------------------------------- | ||
|
|
||
| .radio-group-top { | ||
| @include globals.typography(globals.$ion-body-md-regular); | ||
|
|
||
| margin-bottom: globals.$ion-space-400; | ||
| } | ||
|
|
||
| .radio-group-top .error-text { | ||
| color: globals.$ion-semantics-danger-800; | ||
| } | ||
|
|
||
| .radio-group-top .helper-text { | ||
| color: globals.$ion-primitives-neutral-800; | ||
| } | ||
|
|
||
| // Radio Group Top: in List | ||
| // -------------------------------------------------- | ||
|
|
||
| // Add padding to the error and helper text when used in a | ||
| // list to align them with the list header and item text. | ||
| ion-list .radio-group-top { | ||
| /* stylelint-disable */ | ||
| @include globals.ltr() { | ||
| padding-right: globals.$ion-space-400; | ||
| padding-left: calc(globals.$ion-space-400 + var(--ion-safe-area-left, 0px)); | ||
| } | ||
|
|
||
| @include globals.rtl() { | ||
| padding-right: calc(globals.$ion-space-400 + var(--ion-safe-area-right, 0px)); | ||
| padding-left: globals.$ion-space-400; | ||
| } | ||
| /* stylelint-enable */ | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| @import "./radio-group.common"; | ||
| @import "../../themes/native/native.globals"; | ||
|
|
||
| // Radio Group: Native | ||
| // -------------------------------------------------- | ||
|
|
||
| .radio-group-wrapper { | ||
| display: inline; | ||
| } | ||
|
|
||
| // Radio Group: Top | ||
| // -------------------------------------------------- | ||
|
|
||
| .radio-group-top { | ||
| line-height: 1.5; | ||
| } | ||
|
|
||
| .radio-group-top .error-text { | ||
| color: ion-color(danger, base); | ||
| } | ||
|
|
||
| .radio-group-top .helper-text { | ||
| color: $text-color-step-300; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+3.36 KB
....ts-snapshots/radio-group-error-text-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.28 KB
...ts-snapshots/radio-group-error-text-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.49 KB
....ts-snapshots/radio-group-error-text-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.4 KB
...ts-snapshots/radio-group-helper-text-ionic-md-ltr-light-Mobile-Chrome-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.25 KB
...s-snapshots/radio-group-helper-text-ionic-md-ltr-light-Mobile-Firefox-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+5.62 KB
...ts-snapshots/radio-group-helper-text-ionic-md-ltr-light-Mobile-Safari-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.