Skip to content

Conversation

brandyscarney
Copy link
Member

Issue number: internal


What is the current behavior?

The ios theme tokens do not exist for the modular themes.

What is the new behavior?

Adds and defines the ios theme tokens. Removes the duplicated --ion-font-family assignment.

Does this introduce a breaking change?

  • Yes
  • No

@vercel
Copy link

vercel bot commented Oct 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Oct 21, 2025 8:01pm

@github-actions github-actions bot added the package: core @ionic/core package label Oct 17, 2025
@brandyscarney brandyscarney marked this pull request as ready for review October 17, 2025 20:51
@brandyscarney brandyscarney requested a review from a team as a code owner October 17, 2025 20:51
@brandyscarney brandyscarney requested review from ShaneK and removed request for a team October 17, 2025 20:51
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from FW-6745 to ionic-modular October 21, 2025 19:56
@brandyscarney brandyscarney changed the title feat(themes): add ios theme tokens and config values feat(themes): add ios theme tokens Oct 21, 2025
@brandyscarney brandyscarney merged commit 81024ab into ionic-modular Oct 21, 2025
50 checks passed
@brandyscarney brandyscarney deleted the FW-6744 branch October 21, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants