chore(deps): add playwright-core as a dev dependency #30827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
package-lockfile to match the structurenextuses so we won't have a mismatch with errors on each branch. It installsplaywright-coreas a dev dependency to align withnext.How to test this:
chore/deps-playwrightnode_modules:rm -rf node_modulesnpx lerna@5 bootstrap --include-dependencies --scope @ionic/core --ignore-scripts -- --legacy-peer-deps && npm run buildgit revert 76cf4bda6anpx lerna@5 bootstrap --include-dependencies --scope @ionic/core --ignore-scripts -- --legacy-peer-deps && npm run build[ ERROR ] TypeScript: node_modules/@axe-core/playwright/dist/index.d.ts:2:22 Cannot find module 'playwright-core' or its corresponding type declarations. L1: import { SerialFrameSelector, RunOptions, AxeResults } from 'axe-core'; L2: import { Page } from 'playwright-core'; [00:58.9] build failed in 6.36 sThis shows that without
playwright-coreinstalled the lerna command in the release process will fail.