Skip to content

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Dec 1, 2025

This updates the package-lock file to match the structure next uses so we won't have a mismatch with errors on each branch. It installs playwright-core as a dev dependency to align with next.

How to test this:

  1. Switch to this branch chore/deps-playwright
  2. Remove node_modules: rm -rf node_modules
  3. Run npx lerna@5 bootstrap --include-dependencies --scope @ionic/core --ignore-scripts -- --legacy-peer-deps && npm run build
  4. ✅ Verify: build is successful
  5. Run git revert 76cf4bda6a
  6. Run npx lerna@5 bootstrap --include-dependencies --scope @ionic/core --ignore-scripts -- --legacy-peer-deps && npm run build
  7. 🛑 Verify: the following error occurs:
    [ ERROR ]  TypeScript: node_modules/@axe-core/playwright/dist/index.d.ts:2:22
              Cannot find module 'playwright-core' or its corresponding
              type declarations.
    
          L1:  import { SerialFrameSelector, RunOptions, AxeResults } from 'axe-core';
          L2:  import { Page } from 'playwright-core';
    
    [00:58.9]  build failed in 6.36 s

⚠️ Please do not push the reverted commit, it is just to show that the new dev dependency is required.

This shows that without playwright-core installed the lerna command in the release process will fail.

@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Dec 1, 2025 10:02pm

@github-actions github-actions bot added the package: core @ionic/core package label Dec 1, 2025
@brandyscarney brandyscarney marked this pull request as ready for review December 1, 2025 22:13
@brandyscarney brandyscarney requested a review from a team as a code owner December 1, 2025 22:13
@brandyscarney brandyscarney requested a review from thetaPC December 1, 2025 22:13
@brandyscarney brandyscarney added this pull request to the merge queue Dec 1, 2025
Merged via the queue into main with commit 2228831 Dec 1, 2025
52 checks passed
@brandyscarney brandyscarney deleted the chore/deps-playwright branch December 1, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants