fix(datetime): add temporary workaround for datetime-ready logic issue on Ionic theme. #30841
+41
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenOsodrac
added
package: core
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BenOsodrac
requested review from
OS-jacobbell,
ShaneK and
brandyscarney
and removed request for
OS-jacobbell and
ShaneK
brandyscarney
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Although the work done on FW-6931, there was still a scenario on MobileUI, inside the ion-modal, where the datetime would disappear. This seems to only happen on iOS 26+, as we were not able to replicate it on version 18.*
What is the new behavior?
As there's already task to better fix this issue across all themes, this PR introduces a small css backdoor, to be able to override the opacity value when necessary. This was done on ionic theme only and the css was split, to have no impact on md and iOS.
datetime.ionic.scss, opacity is now controlled via CSS variables (--body-opacity,--year-opacity) for.calendar-bodyand.datetime-year.datetime.native.scss, explicit opacity rules for.calendar-bodyand.datetime-yearare added, with visibility toggled based on the.datetime-readyclass.datetime.common.scss, redundant and hard-coded opacity rules for.calendar-bodyand.datetime-yearare removed, deferring control to theme-specific stylesheets.A small fix was also done on IonHeader token used for the border-color, to correctly reflect the value from Figma.
Does this introduce a breaking change?