Skip to content

fix(select): compareWith passes params in correct order#25764

Merged
liamdebeasi merged 10 commits into
mainfrom
FW-2048
Aug 22, 2022
Merged

fix(select): compareWith passes params in correct order#25764
liamdebeasi merged 10 commits into
mainfrom
FW-2048

Conversation

@liamdebeasi
Copy link
Copy Markdown
Contributor

@liamdebeasi liamdebeasi commented Aug 16, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #25759

What is the new behavior?

  • The textForValue function now passes the ion-select value first when calling compareOptions (previously it was the option value first).

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi changed the title Fw 2048 fix(select): compareWith passes params in correct order Aug 16, 2022
@github-actions github-actions Bot added the package: core @ionic/core package label Aug 16, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review August 16, 2022 20:12
@liamdebeasi liamdebeasi requested a review from a team August 16, 2022 20:12
Comment thread core/src/components/select/test/compare-with/select.e2e.ts Outdated
@sean-perkins sean-perkins self-requested a review August 17, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-select popover does show the selected value in the opened popover

3 participants