Skip to content

fix(datetime): time button is easier to access with screen readers#26019

Merged
sean-perkins merged 4 commits into
mainfrom
fix/datetime-a11y-calendar-body
Sep 27, 2022
Merged

fix(datetime): time button is easier to access with screen readers#26019
sean-perkins merged 4 commits into
mainfrom
fix/datetime-a11y-calendar-body

Conversation

@sean-perkins
Copy link
Copy Markdown
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When screen readers announce the datetime body, the previous (not visible), current (visible) and next month (not visible) are announced.

Issue URL: Internal

What is the new behavior?

  • Only the working month (current month) is announced to screen readers
  • Focus can be easily moved to the time picker (if enabled), or outside of the calendar body

Does this introduce a breaking change?

  • Yes
  • No

Other information

Split from: #25980

@github-actions github-actions Bot added the package: core @ionic/core package label Sep 26, 2022
@sean-perkins sean-perkins marked this pull request as ready for review September 26, 2022 20:34
@sean-perkins sean-perkins requested a review from a team as a code owner September 26, 2022 20:34
Copy link
Copy Markdown
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Can we update the commit title to something more descriptive of the fix? The working month has always been announced by screen readers. Maybe something like fix(datetime): time button is easier to access with screen readers or fix(datetime): swiping with screen reader no longer incorrectly changes month

Comment thread core/src/components/datetime/datetime.tsx Outdated
@sean-perkins sean-perkins changed the title fix(datetime): working month is announced to screen readers fix(datetime): time button is easier to access with screen readers Sep 27, 2022
@sean-perkins sean-perkins merged commit 5846b41 into main Sep 27, 2022
@sean-perkins sean-perkins deleted the fix/datetime-a11y-calendar-body branch September 27, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants