Skip to content

feat(modal): data and role are passed to canDismiss#26384

Merged
liamdebeasi merged 5 commits into
feature-6.4from
FW-2829
Dec 2, 2022
Merged

feat(modal): data and role are passed to canDismiss#26384
liamdebeasi merged 5 commits into
feature-6.4from
FW-2829

Conversation

@liamdebeasi
Copy link
Copy Markdown
Contributor

@liamdebeasi liamdebeasi commented Nov 30, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #26292

What is the new behavior?

  • The canDismiss handler now receives data and role parameters. These is the same information that is passed to the dismiss method.
  • When dismissing via a gesture, the data will be undefined and the role will be 'gesture'.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions Bot added the package: core @ionic/core package label Nov 30, 2022
@liamdebeasi liamdebeasi marked this pull request as ready for review November 30, 2022 19:47
@liamdebeasi liamdebeasi requested a review from a team as a code owner November 30, 2022 19:47
Comment thread core/src/components/modal/gestures/utils.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants