-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(menu): update location when dynamically changing side or doc dir #27079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
The newly added test is failing because it includes new screenshot checks. Make sure you run the Update Reference Screenshots job for this branch 👀 (I often like to leave my PRs in draft until all tests are passing, so it's more clear that it's actually ready for review.) |
|
@amandaejohnston I've updated the references and the PR is ready to go. |
averyjohnston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just had a small request on the tests.
averyjohnston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
<ion-menu side='start'>will always be on the left side regardless of direction.Issue URL: resolves #25601 #19489
What is the new behavior?
Does this introduce a breaking change?
Other information
N/A