feat(alert):adding alert multi line input

[tawfiek]

Short description of what this resolves:

Adds the possibility to add a textarea in ion alert.

Changes proposed in this pull request:

• Android
  

• IOS
  

Version: 4.0.0-beta.19

Fixes: #14153

[robingenz]

When is this getting merged?

[liamdebeasi]

I think there needs to be a discussion as to what the final API should look like, but looks good so far! Left a few comments below.

Are there any other props for textarea that we should support? Maybe @brandyscarney has some ideas here. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea

[liamdebeasi]

Also, can you fix the merge conflicts? Thanks!

[tawfiek]

I plan to work on these changes at the weekend.
@robingenz @liamdebeasi

[tawfiek]

Done.
any other comments ?!
@liamdebeasi

[liamdebeasi]

Hey there,

Sorry for the delay in reviewing. This is looking great! Could you add another test to basic/index.html?

Also, the resize: vertical doesn't seem to be working. I was thinking of just getting rid of resize altogether since ion-textarea doesn't have it. Thoughts @brandyscarney?

[brandyscarney]

@liamdebeasi That sounds good.

I think this addition is misleading:

ion-input,prop,type,"date" | "email" | "number" | "password" | "search" | "tel" | "text" | "textarea" | "time" | "url",'text',false,false

ion-input won't allow a textarea to be passed as a type.

[tawfiek]

@liamdebeasi That sounds good.

I think this addition is misleading:

ion-input,prop,type,"date" | "email" | "number" | "password" | "search" | "tel" | "text" | "textarea" | "time" | "url",'text',false,false

ion-input won't allow a textarea to be passed as a type.

I thought about this
Any Ideas make it less misleading
@brandyscarney

[tawfiek]

any updates here !

[robingenz]

Any updates?

[brandyscarney]

Besides testing out the UI, I think this is fine to add once merge conflicts and comments are addressed. 🙂

[brandyscarney]

The code updates look good! We just need to test out the UI and then the merge conflicts need to be resolved. I'll add this to our needs review!

[brandyscarney]

@tawfiek Is there any way you can fix the merge conflicts on this? I attempted to but it wouldn't let me push to your remote.

[brandyscarney]

UI looks good. 👍 Just need to fix the merge conflicts.

[tawfiek]

I am done, but the CI builds fail in test-core-clean-build honestly I have no idea why this build is failing.
@brandyscarney.

[liamdebeasi]

@tawfiek You need to run npm run build from the core directory and then commit/push those changes.

[liamdebeasi]

Can you also add a test for this? You can just add the following to alert/test/basic/index.html:134

{
  type: 'textarea',
  placeholder: 'Placeholder 4',
  value: 'Textarea hello'
},

After that we should be good to merge.

[liamdebeasi]

Great work!

[brandyscarney]

@tawfiek Thanks so much for your patience and working with us on this. 🎉