fix(ion-infinite-scroll): change scroll handler to use scrollEl instead of host #18647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresI didn't change or add any tests since this should simply be restoring functionality. I'm confused about how it was working before because it was listening for a scroll event on the element's host and not the actual scrolling element.
If the ion-infinite-scroll is meant to be the scrolling element, then we could ditch this PR and make the appropriate updates to usage docs.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #18632
What is the new behavior?
Does this introduce a breaking change?
Other information
My goal is to use this in an existing stencil app, so I wrote a test case for that. I didn't include it in the commit, but here it is in case it helps someone.