fix(ios): translucent toolbar blur no longer obscures entering page title#20314
Merged
liamdebeasi merged 10 commits intomasterfrom Jan 29, 2020
Merged
fix(ios): translucent toolbar blur no longer obscures entering page title#20314liamdebeasi merged 10 commits intomasterfrom
liamdebeasi merged 10 commits intomasterfrom
Conversation
|
|
||
| @supports (backdrop-filter: blur(0)) { | ||
| .header-translucent-ios { | ||
| .header-background { |
Member
There was a problem hiding this comment.
Wouldn't this apply to MD too?
Contributor
Author
There was a problem hiding this comment.
It's in the header.ios.scss file, so it should be fine, right? Or do I still need .header-translucent-ios .header-background?
Member
There was a problem hiding this comment.
I thought that scoped used to do that, but I'm seeing it work fine. I wonder why we specify the class + mode in all of the CSS files though instead of just using .header-translucent or ion-header then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #19158
What is the new behavior?
'.header-backgroundwhere the backdrop filter will be applied to.Does this introduce a breaking change?
Other information