Skip to content

fix(header): collapsible header now works when navigating quickly#20728

Merged
liamdebeasi merged 2 commits intomasterfrom
large-title-race
Mar 11, 2020
Merged

fix(header): collapsible header now works when navigating quickly#20728
liamdebeasi merged 2 commits intomasterfrom
large-title-race

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20725

What is the new behavior?

  • Adding the header-collapse-main class happens in a writeTask which is async, so the element may not exist when the callback gets run. Added a check to only add the class if the element exists.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 9, 2020
@liamdebeasi liamdebeasi merged commit 87a2721 into master Mar 11, 2020
@liamdebeasi liamdebeasi deleted the large-title-race branch March 11, 2020 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant