Skip to content

fix(modal): backdrop and box shadows no longer stack when opening multiple modals#20801

Merged
liamdebeasi merged 1 commit intomasterfrom
multi-modal
Mar 18, 2020
Merged

fix(modal): backdrop and box shadows no longer stack when opening multiple modals#20801
liamdebeasi merged 1 commit intomasterfrom
multi-modal

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20800

What is the new behavior?

  • Only apply box shadow/backdrop opacity styles to the first modal

Does this introduce a breaking change?

  • Yes
  • No

Other information

iOS Changes:

master branch
modal-ios-before modal-ios-after

MD changes:

master branch
modal-md-before modal-md-after

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants