Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #20948

What is the new behavior?

  • Account for tabs where there is no tab selected

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Apr 2, 2020
@liamdebeasi liamdebeasi changed the title fix(tabs): transition properly when using dynamically generated tabs fix(ios): account for nested tabs with page transition Apr 2, 2020
@liamdebeasi liamdebeasi merged commit e23dec5 into master Apr 2, 2020
@liamdebeasi liamdebeasi deleted the tabs-anim branch April 2, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants