feat(all): add optional typing of methods with generics of OverlayEventDetail#21393
Merged
liamdebeasi merged 1 commit intoionic-team:masterfrom Jun 3, 2020
Merged
Conversation
…d optional typing of methods with generics of OverlayEventDetail add optional generic type of all methods like onDidDismiss and onWillDismiss Refs ionic-team#21368
liamdebeasi
changed the title
Contributor
|
Here is a dev build if anyone would like to test it out: |
liamdebeasi
approved these changes
Jun 2, 2020
brandyscarney
approved these changes
Jun 2, 2020
Contributor
|
Merged. Thank you! |
This was referenced Jun 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Current behavior - there is no optional typing of generic usages
OverlayEventDetailIssue Number: resolves #21368
What is the new behavior?
OverlayEventDetailDoes this introduce a breaking change?
Other information