refactor servers_list#487
Merged
Merged
Conversation
ocefpaf
force-pushed
the
refactor_servers_list
branch
from
3783faf to
5e525f9
Compare
ocefpaf
force-pushed
the
refactor_servers_list
branch
from
5e525f9 to
211aa99
Compare
Member
Author
|
@jemrobinson and @gmaze would this help solve euroargodev/argopy#645? |
|
@ocefpaf: I haven't tested it, but yes, I think this might work. Thank you! |
Member
Author
|
I'll merge and mint a new release. Note that this is kind of a breaking change, but the server list functionality was never really meant for public use anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we try to never load the server list unless we are about to use it and make it semi-private. Users can still initialize it if they need, but it was never intended to be a public feature.
Help mitigate euroargodev/argopy#645.