This repository was archived by the owner on Jan 13, 2023. It is now read-only.
fix transfer = ProposedTransaction(...) naming convention doesn't follow other libs #72 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @szepnapot! Thanks for your pull request! I will have a look at this later today. |
todofixthis
suggested changes
Sep 30, 2017
Contributor
There was a problem hiding this comment.
I feel like we could make this even simpler.
What if we just made Transfer an alias for ProposedTransaction?
class ProposedTransaction(Transaction):
...
Transfer = ProposedTransaction
"""
Follow naming convention of other libs.
https://github.com/iotaledger/iota.lib.py/issues/72
"""That way, we don't have to keep the two initialiser functions in sync if we make changes to ProposedTransaction.
Contributor
Author
|
True! I'll modify according to it. Thanks the review :) |
Contributor
Author
|
Changed as suggested :) |
Contributor
|
Thanks! I'll have a look this evening. |
todofixthis
approved these changes
Oct 3, 2017
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Looks good! Thanks!! Merging now.
marko-k0
pushed a commit
to marko-k0/iota.lib.py
that referenced
this pull request
Jul 28, 2018
fix transfer = ProposedTransaction(...) naming convention doesn't follow other libs iotaledger-archive#72
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72