Fix unarchiving a repo#164
Merged
galargh merged 1 commit intoipdxco:masterfrom Apr 7, 2025
Merged
Conversation
Before this change, `toggleArchivedRepos` would prevent the unarchiving of a repository because it didn't set the state repo's `archived` property to `false`.
galargh
approved these changes
Apr 7, 2025
Member
galargh
left a comment
galargh
left a comment
There was a problem hiding this comment.
Another great catch! This is really surprising! I guess, throughout all these years, noone actually tried unarchiving a repo in any of the organizations I manage 😅
Looking at your PR, I noticed that the use of "action" and "runAction" is quite inconsistent in the current implementation. I tried to address this in #169 I also modified the test resources a bit there to make the test you added a little easier to read, I hope you don't mind. Thank you for adding it by the way. More test coverage would definitely be beneficial here 🙇
I'm going to merge this one as-is, and then I'll merge my follow-up. It should be easier that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change,
toggleArchivedReposwould prevent the unarchiving of a repository because it didn't set the state repo'sarchivedproperty tofalse.