Merged
Conversation
Merged
galargh
force-pushed
the
unify-shared-actions-signatures
branch
from
05fc7d2 to
e75ba4d
Compare
There was a problem hiding this comment.
Copilot reviewed 19 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (1)
- scripts/tests/resources/terraform/terraform.tfstate: Language not supported
Comments suppressed due to low confidence (1)
scripts/src/actions/shared/add-file-to-all-repos.ts:6
- The function runAddFileToAllRepos is missing the export keyword, making it inaccessible externally. Consider adding 'export' before the function declaration to ensure consistency with other run functions.
async function runAddFileToAllRepos(
galargh
commented
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #165
It ensures all the shared actions follow the same pattern of:
actionfunction not touching the files on diskrunActionfunction ensuring the changes of theactionare written to the file system