Skip to content

test(dag/walker): fix flaky bloom FP assertion#1139

Merged
lidel merged 1 commit intomainfrom
fix/bloom-tracker-flaky-test
Apr 10, 2026
Merged

test(dag/walker): fix flaky bloom FP assertion#1139
lidel merged 1 commit intomainfrom
fix/bloom-tracker-flaky-test

Conversation

@lidel
Copy link
Copy Markdown
Member

@lidel lidel commented Apr 10, 2026

Allow up to 2 false positives instead of exactly 0 in the default-rate regression test. At 1 in 4.75M with 100K probes the expected count is ~0.02, giving a ~2% flake rate for an exact-zero assertion.

I think the purpose of the test should be to warn us if suddenly something gets totally out of whack, and it should not make our live miserable by being flaky, so dialing this a notch down should be a good compromise.

Allow up to 2 false positives instead of exactly 0 in the
default-rate regression test. At 1 in 4.75M with 100K probes
the expected count is ~0.02, giving a ~2% flake rate for an
exact-zero assertion.
@lidel lidel requested a review from a team as a code owner April 10, 2026 17:52
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.99%. Comparing base (a696a54) to head (0656e97).
⚠️ Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   63.00%   62.99%   -0.01%     
==========================================
  Files         266      266              
  Lines       26661    26661              
==========================================
- Hits        16797    16795       -2     
- Misses       8149     8150       +1     
- Partials     1715     1716       +1     

see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lidel lidel merged commit 956010c into main Apr 10, 2026
16 of 17 checks passed
@lidel lidel deleted the fix/bloom-tracker-flaky-test branch April 10, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant