test(dag/walker): fix flaky bloom FP assertion#1139
Merged
Conversation
Allow up to 2 false positives instead of exactly 0 in the default-rate regression test. At 1 in 4.75M with 100K probes the expected count is ~0.02, giving a ~2% flake rate for an exact-zero assertion.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1139 +/- ##
==========================================
- Coverage 63.00% 62.99% -0.01%
==========================================
Files 266 266
Lines 26661 26661
==========================================
- Hits 16797 16795 -2
- Misses 8149 8150 +1
- Partials 1715 1716 +1 see 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow up to 2 false positives instead of exactly 0 in the default-rate regression test. At 1 in 4.75M with 100K probes the expected count is ~0.02, giving a ~2% flake rate for an exact-zero assertion.
I think the purpose of the test should be to warn us if suddenly something gets totally out of whack, and it should not make our live miserable by being flaky, so dialing this a notch down should be a good compromise.