Skip to content

Contributing: remove irc mention#459

Merged
hsanjuan merged 3 commits intomasterfrom
contributing/remove-irc-mention
Mar 23, 2020
Merged

Contributing: remove irc mention#459
hsanjuan merged 3 commits intomasterfrom
contributing/remove-irc-mention

Conversation

@hsanjuan
Copy link
Copy Markdown
Contributor

It is more effective to just ping the maintainer.

@hsanjuan hsanjuan self-assigned this Mar 20, 2020
Comment thread CONTRIBUTING.md Outdated
We are always thrilled to receive pull requests, and do our best to process them as quickly as possible. However, if you are not sure if that typo is worth a pull request? Do it! We will appreciate it.

If you don't get a response to a pull request within a few days, feel free to mention it in the #ipfs IRC channel. We may be able to get to it faster.
If you don't get a response to a pull request within a few days, feel free to ping the repository maintainer, captain or last person to merge something in that repository.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still suggest pinging people on IRC. It can be hard to tell who the maintainer is or who best to ask but if you ask on IRC, you'll eventually be directed to the right person.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see people posting on IRC and not getting any help because we don't look so much into it. Finding who to ping on IRC is equivalent to finding who to ping directly on the issue and does not require getting out of github and figuring out what is IRC and what our channels are.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. But I also get quite a few direct pings on IRC for things I've been ignoring on github. It's nice having a second channel.

Maybe both?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, how does it look now?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hsanjuan hsanjuan merged commit cf833f0 into master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants