chore: add js documentation contributing guidelines#474
Conversation
|
The only reason I was advocating for putting typedefs at the bottom as opposed to top is because it improves readability of the code (in my opinion anyway). You can get a general idea / bigger picture of what the code does and lookup additional details by scrolling to references (types or not). Putting all the jsdoc typedefs (which are ofter verbose in jsdoc style) in my experience creates opposite effect where I have to scroll quite a bit before I can get to read what the primary piece of code and then have scroll back up to lookup details. Here is the discussion thread we had before on this (quoting for convenience here):
If this is just me, I have no reason to object to this. Furthermore I think we have general consensus towards defining types and interfaces in the Typedefs and interfaces should go into |
I have no objections to this. |
This seems good. @Gozala can you suggest a change regarding this? |
|
Merging this. We can iterate on it afterward |
Per sync discussion, this PR adds JS documentation contributing guidelines based on JSDoc based types.
The general decision is that type definition should be placed on the top of JS files.
cc @ipfs/js-core-team