Skip to content

fix: calling message queue Shutdown twice causes panic #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dirkmc merged 1 commit into from
Mar 21, 2023
Merged

fix: calling message queue Shutdown twice causes panic #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion messagequeue/messagequeue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ type MessageQueue struct {

outgoingWork chan struct{}
done chan struct{}
doneOnce sync.Once

// internal do not touch outside go routines
sender gsnet.MessageSender
Expand Down Expand Up @@ -144,7 +145,9 @@ func (mq *MessageQueue) Startup() {

// Shutdown stops the processing of messages for a message queue.
func (mq *MessageQueue) Shutdown() {
close(mq.done)
mq.doneOnce.Do(func() {
close(mq.done)
})
}

func (mq *MessageQueue) runQueue() {
Expand Down