This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Request builder #107
Merged
Request builder #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Stebalien
force-pushed
the
feat/request-2
branch
from
9ad371f to
46768a3
Compare
Stebalien
commented
Jul 16, 2018
| data := new(bytes.Buffer) | ||
| err := json.NewEncoder(data).Encode(obj) | ||
| var data bytes.Buffer | ||
| err := json.NewEncoder(&data).Encode(obj) |
| }() | ||
|
|
||
| return nil | ||
| defer resp.Close() |
Member
Author
There was a problem hiding this comment.
correct error handling
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An extension/replacement of #98 that allows specifying options. The last commit in this PR replaces uses of
newRequestwith the new builder (removing a bunch of code).