This repository was archived by the owner on Feb 7, 2024. It is now read-only.
Request, RequestDecode, swarm peers, stats bw #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
magik6k
reviewed
Jul 11, 2018
| // the stats of the requested Object or an error. | ||
| func (s *Shell) StatsBW() (*p2pmetrics.Stats, error) { | ||
| v := &p2pmetrics.Stats{} | ||
| err := s.RequestDecode(context.TODO(), &v, "stats/bw") |
Member
There was a problem hiding this comment.
Other functions use..Background
Member
There was a problem hiding this comment.
Even better, let's just take a context (it's a new command).
| } | ||
|
|
||
| func (s *Shell) Request(ctx context.Context, command string, args ...string) (*Request, *Response, error) { | ||
| req := s.newRequest(ctx, command, args...) |
Member
There was a problem hiding this comment.
Maybe allow passing option map here too?
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a couple commands, so i implemented them:
I wanted a general way to issue commands to be exported,
so i added that. As described in #92