v2.9.2 bump#184
Merged
Merged
Conversation
|
Suggested tag: Changes in configuration file(s): diff --git a/go.mod b/go.mod
index 7220406..6a958b8 100644
--- a/go.mod
+++ b/go.mod
@@ -1,11 +1,11 @@
module github.com/ipfs/go-log/v2
-go 1.24
+go 1.25
require (
- github.com/mattn/go-isatty v0.0.20
+ github.com/mattn/go-isatty v0.0.22
github.com/stretchr/testify v1.11.1
- go.uber.org/zap v1.27.1
+ go.uber.org/zap v1.28.0
)
require (
Automatically created GitHub ReleaseA draft GitHub Release has been created. |
Contributor
|
I think a patch release is reasonable here as this fixes an interaction between slog and zap, and is not adding any new feature. I would not consider the changes to the log output to constitute a behavior change worthy of a bigger version bump, because it is essentially fixing broken output, and nothing should rely on that particular output, especially since it is generally empty. No problems with kubo: ipfs/kubo#11325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤷 is this patch worthy or does mateirally changing the output of someone's logs count for more than that? @lidel what do you think?