fix: handle dnslink pointing to CID with peer id (ipns name)#722
Merged
fix: handle dnslink pointing to CID with peer id (ipns name)#722
Conversation
2color
force-pushed
the
fix-dnslink-to-ipns
branch
from
35a2065 to
6f9076c
Compare
achingbrain
previously requested changes
Jan 22, 2025
Member
achingbrain
left a comment
achingbrain
left a comment
There was a problem hiding this comment.
Thanks - can you please add a test to ensure there are no future regressions?
Member
Author
|
Tests are in place |
2color
changed the title
2color
changed the title
Merged
This was referenced Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR
fixes #721
Notes & open questions
Change checklist