Skip to content

Conversation

@2color
Copy link
Member

@2color 2color commented Aug 18, 2022

What's in this PR

  • Fixes links to the forum from .io to .tech
  • Adds the cid keyword to the title for the content addressing page
  • Improves the headers for the content addressing page to be more readable and SEO friendly
  • Rename the Server Infrastructure page to IPFS cluster

Background

I was baffled to discover we're not the first result for ipfs cid on Google, only to discover we don't have the keyword in the title

Screen Shot 2022-08-18 at 11 19 54 AM

@2color 2color requested a review from TMoMoreau August 18, 2022 09:19
@2color 2color marked this pull request as draft August 18, 2022 12:39
@2color 2color changed the title seo: add cid to the content addressing page title SEO fixes Aug 18, 2022
@2color 2color marked this pull request as ready for review August 18, 2022 13:11
@2color 2color requested a review from TheDiscordian August 18, 2022 13:12
Copy link
Collaborator

@mishmosh mishmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I agree with renaming server infrastructure to IPFS Cluster. Calling it "server infra" or something descriptive is more likely to catch the attention of users who don't know that Cluster is the solution to their problem. I believe this has been an issue historically. Can you git blame to find who made that change initially and discuss with them?

Everything else looks great, thank you. Your cleanups are a good reminder (for me and hopefully others too) that when deleting or renaming anything, we should also search the full repo for references to that thing and clean up accordingly.

How about forking the "server infrastructure" change into a separate PR and merging everything else?

@filecorgi
Copy link
Contributor

  • Image optimization came back clean!
  • Vuepress build was successful!

@2color
Copy link
Member Author

2color commented Aug 18, 2022

I am not sure I agree with renaming server infrastructure to IPFS Cluster. Calling it "server infra" or something descriptive is more likely to catch the attention of users who don't know that Cluster is the solution to their problem. I believe this has been an issue historically. Can you git blame to find who made that change initially and discuss with them?

Sounds good. I've reverted the change for now

It looks like it was server infrastructure from the get-go 91e5026#diff-1c3779e94655b66d9a2ec90eb95bfcf977a0e04ccc41fc9e2974594e6b5a7d32

@mishmosh mishmosh self-requested a review August 18, 2022 15:08
@2color 2color merged commit ca3a3f5 into main Aug 18, 2022
@2color 2color deleted the update-cid-title branch August 18, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants