Add a note about Snap confinement#605
Add a note about Snap confinement#605johnnymatthews merged 6 commits intoipfs:mainfrom gammazero:patch-1
Conversation
Users who want to know how to install IPFS may not be aware of Snap's [confinement](https://snapcraft.io/docs/snap-confinement) behavior. So, I thought it useful to add a note someplace where they might see it before they install the Ubuntu Snap package. Hopefully, this can prevent issues like this one: ipfs/kubo#7872
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
|
cc @olizilla, does this sound good to you? |
olizilla
left a comment
There was a problem hiding this comment.
Yes indeed! Good idea to warn about it. I would use a ::: callout or similar to highlight it, and move it to directly below the table.
|
Moved the warning into a |
|
@gammazero I'm not sure this is actually enough. Since the snap has We should probably just change to telling people to use |
|
Updated the instructions to use
What's required for this? |
|
The snap default is strict confinement. The ipfs snap has always had strict confinement. Are lots of folks getting suprised by that? The installing user can add and get files via an ipfs daemon installed by snap, so I'm not clear on what the problem is. Snap is not other package managers, and we should be careful around our assumptions of how things should work. We should definitely review the list plugs and add any that are missing tho. I am mildly against reducing the confinment at this point unless i am missing some context. |
|
Right. In that case, I'm not sure what to do here then. Installing IPFS with Snap is easy to set up and for most folks to use, but comes with confinement complications. I'd like to keep a simple one-liner here for Ubuntu users though. |
|
The best thing would be to caveat it in the docs for now, similar to the orginal PR, and open an issue on go-ipfs to review the snap.yml config to make it as un-annoying as possible, given that snaps defaults are much stricter than other package managers. |
Provide a bit more explanation for snap: 1. An explanation that Snap has container permissions + link 2. Say that it gives permissions to `/home` 3. Link that describes how to grant access to
Users who want to know how to install IPFS may not be aware of Snap's confinement behavior. So, I thought it useful to add a note someplace where they might see it before they install the Ubuntu Snap package.
Hopefully, this can prevent issues like this one: ipfs/kubo#7872