Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Looks like CI failures due to missing int64/uint64 conversions. |
Contributor
Author
I am surprised these have different types on macos vs linux. |
Contributor
Author
|
test failures look unrelated |
Report the free space of the volume backing the IPFS repo so that tools like macOS Finder see real numbers instead of zeros. - add Statfs to writable.Dir (serves /mfs and /ipns child dirs), readonly.Root (/ipfs), and ipns.Root (/ipns) - thread RepoPath from the repo through Config / CreateRoot - unit test for Dir.Statfs and empty-path guard - FUSE integration tests on all three mounts comparing mount-point stats against the repo directory
lidel
approved these changes
Apr 10, 2026
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Thanks @wjmelements for flagging this!
The original PR was written against bazil.org/fuse which has since been replaced by hanwen/go-fuse in #11272, so
the code no longer applied. I've rebased, resolved conflicts, and reimplemented statfs on top of the new FUSE stack:
writable.Dir(serves/mfsand/ipnschild dirs),readonly.Root(/ipfs), andipns.Root(/ipns) all implementNodeStatfsernowRepoPathis threaded from the repo through to each mount sosyscall.Statfshas a real target- Unit and FUSE integration tests on all three mounts verify the returned stats match the repo's backing volume
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer @lidel
On macOS, Finder uses statfs(2) to check if there is enough space for a file before copying.
Without this, writing can fail with error ('there isn't enough free space').
I have only seen this issue with Finder but it's possible that statfs(2) is used by other fs browsers, so it is good to implement it.
Changes