Closed
Conversation
Member
Author
|
Should I recreate this PR for dev0.4.0? |
Looks like it's already based off dev0.4.0 right? |
Member
Author
|
I wrote under wrong PR. Sorry for that. (I should have been sleeping instead of codding and looking through github). |
cf514d8 to
3224ae0
Compare
As for now only dnslink is valid. Fixes ipfs#760 License: MIT Signed-off-by: Jakub (Kubuxu) Sztandera <kubuxu@gmail.com>
Member
Author
|
It is set to merge to dev0.4.0. Instead of merging it via GH, you have to manually pull this branch into master. |
Member
|
@Kubuxu will be easier if you push a new PR i think. we want CI to run on top of master. |
Member
Author
|
See #2193. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As for now only dnslink is valid.
Fixes #760
License: MIT
Signed-off-by: Jakub (Kubuxu) Sztandera kubuxu@gmail.com