fix(Dockerfile)

[btc]

removed ipfs init (so that the image ships no longer ships with an identity)

TODO Maybe allow an init flag ipfs --init run? It's important to keep the initialization process simple. Open to alternatives. It would be nice to be able to ship an image that users can pull and execute in one command.

[jbenet]

Maybe:

# set bootstrap through ENV
ENV IPFS_BOOTSTRAP /ip4/0.0.0.0/tcp/4001

# maybe want ENTRYPOINT [1]
ENTRYPOINT ["ipfs"]

# args to IPFS
CMD ["run"]

once #251 is done

[1] From http://docs.docker.com/reference/builder/#cmd

Unlike the behavior of the CMD instruction, The ENTRYPOINT instruction adds an entry command that will not be overwritten when arguments are passed to docker run. This allows arguments to be passed to the entry point, i.e. docker run <image> -d will pass the -d argument to the entry point.

[jbenet]

Maybe allow an init flag ipfs --init run?

What's the semantics if it's already inited? seems error prone. (maybe --init-once to be clear)

It's important to keep the initialization process simple.

• 10^100

It would be nice to be able to ship an image that users can pull and execute in one command.

Completely agreed.

[btc]

--init-once works.

Alternatively, --initialized #cheriton

[btc]

@jbenet RTM

[jbenet]

@maybebtc i merged, but i still think we should change this to an entrypoint at some point.

[btc]

Ah you rewrote history 🐍

😄 I'll change over once I've had a chance to try it out.

[jbenet]

@maybebtc ??? i didnt rewrite history, i just clicked Merge after seeing RTM.

[btc]

Oh no. I didn't see your comment about ENTRYPOINT. And thought that you'd edited comment that mentioned --init run. I must've just misread.