Conversation
Kubuxu
force-pushed
the
feat/pnet
branch
7 times, most recently
from
ab2f1e1 to
5c07c12
Compare
|
@whyrusleeping it should be ready for CR. |
| return du, err | ||
| } | ||
|
|
||
| func (r *FSRepo) SwarmKey() ([]byte, error) { |
There was a problem hiding this comment.
Shall the swarm key be part of the ipfs configuration file (as the host identity is?). My first impression is that it would be a more consistent approach.
There was a problem hiding this comment.
No, as we want to move the privkey out of the config for a long time already.
There was a problem hiding this comment.
Config is exposed via the HTTP API and right now we some ugly hacks to not expose the privkey over the API.
There was a problem hiding this comment.
It could be part of keystore but as keystore isn't scheduled yet it will have to work for now. In future we can migrate it into keystore.
There was a problem hiding this comment.
Word, it would be great if we could move the private key out of the config file in a similar fashion 👍
| ' | ||
|
|
||
| test_expect_success "try connecting node in public network with priv networks" ' | ||
| iptb connect [1-4] 0 |
There was a problem hiding this comment.
huh, maybe iptb should return failure if one of those doesnt succeed?
There was a problem hiding this comment.
they all fail right now and iptb doesn't return anything.
There was a problem hiding this comment.
Yeah, Thats probably something I should get around to fixing on iptb. Seems like a 'bug'.
That said, i don't have any issue with your tests, was just remarking on iptb usage.
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Largely LGTM 👍, one comment about a test
| return du, err | ||
| } | ||
|
|
||
| func (r *FSRepo) SwarmKey() ([]byte, error) { |
There was a problem hiding this comment.
Word, it would be great if we could move the private key out of the config file in a similar fashion 👍
|
|
||
| test_expect_success "node 3 (pnet 2) swarm is empty" ' | ||
| ipfsi 3 swarm peers && | ||
| [ $(ipfsi 3 swarm peers | wc -l) -eq 0 ] |
There was a problem hiding this comment.
Should this test wait a bit to make sure it really didn't connect?
There was a problem hiding this comment.
The iptb connect command waits for the connect call to finish, by then it is either for sure connected or not.
Kubuxu
force-pushed
the
feat/pnet
branch
5 times, most recently
from
79f57de to
7ac74c1
Compare
|
|
||
| test_init_ipfs | ||
|
|
||
| export LIBP2P_FORCE_PNET=1 |
There was a problem hiding this comment.
I'd find very useful that there was a similar option in the ipfs config file. "EnablePrivateNetworks" kind of thing. Also, an option to indicate the path to the key?
There was a problem hiding this comment.
Agreed with this, but i'm wanting to avoid using config values for features that are currently experimental. Once private networks are more well defined, we can make it an official feature and give it config values to use
|
@Kubuxu what is the status on the review of the private net crypto code? |
|
@jbenet told me that he will review it tomorrow, it was 3 days ago. |
ghost
removed their assignment
Kubuxu
force-pushed
the
feat/pnet
branch
3 times, most recently
from
e085c67 to
5b4f4e1
Compare
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
|
@Kubuxu can we close this now that the other PR merged? |
|
Yes |
4 participants
Resolves #3313
Almost done, I still want to create file transfer tests.File transfer tests are down waiting for final CR.