p2p/net: dial log -> events#676
Merged
Merged
Conversation
This commit turns all dial logs into log.Events.
Everything's great except for one problem:
The LoggableMap I'm using does not print out things
correctly. I gave it peer.IDs, and Multiaddrs
and both got logged as nothing `{}` (didn't even call
their String() methods!) So, for now, this function
encodes it when called... This is wrong and should be
fixed before being merged in. Otherwise we will be
constantly encoding peer.IDs and Multiaddrs without
needing to.
@briantigerchow how do you suggest doing this?
I don't know my way around your Loggable.
Member
Author
|
Aaaaand this way of doing it causes races. so has to be done another way. This is basically what i want to do. @briantigerchow how should I do it right? |
Contributor
There was a problem hiding this comment.
Thought: rather than producing another event... Since d.PrivateKey == nil is known apriori, let insecure be included on the original event.
+ fixed race
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit turns all dial logs into log.Events.
Everything's great except for one problem: The LoggableMap I'm using does not
print out things correctly. I gave it peer.IDs, and Multiaddrs and both got
logged as nothing
{}(didn't even call their String() methods!) So, for now,this function encodes it when called... This is wrong and should be fixed
before being merged in. Otherwise we will be constantly encoding peer.IDs and
Multiaddrs without needing to.
@briantigerchow how do you suggest doing this? I don't know my way around your
Loggable things.