Conversation
Member
There was a problem hiding this comment.
Hrm... I need to modify seek to perform No-op's if you seek to the files current offset.
Member
|
LGTM |
Member
Author
|
@whyrusleeping can you check the ipns part? |
This commit changed the "ReadAll" to do proper read requests. Seeking in fuse mounted fs now works. Note: this is why opening a mounted video didnt work... we just didnt look at this code in months.
Member
There was a problem hiding this comment.
I dont like that we have to do this... after the alpha im going to do a heavy refactor on the entire ipns subsystem and make it a lot better.
Member
There was a problem hiding this comment.
create a new dagReader on each read. Its not a light operation.
Member
|
The ipns stuff looks good because we disallow writing for now. Once writing is reenabled we will have to change some things. in other words, LGTM |
Member
Author
|
okay |
Member
There was a problem hiding this comment.
Oh crap, i missed this. We dont need to construct a new reader. The Node object has one in it already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changed the "ReadAll" to do proper read requests.
Seeking in fuse mounted fs now works. Note: this is why opening a
mounted video didnt work... we just didnt look at this code in
months.