Conversation
whyrusleeping
changed the title
Member
There was a problem hiding this comment.
curious why the change here? for readability or was there a bug?
Member
Author
There was a problem hiding this comment.
mostly paranoid about this: http://play.golang.org/p/YSy0gaUefy
Member
|
Sharness test pls. we shouldn't be adding more code without tests. I want to make fixing tests high priority. (it makes it annoying to develop.) |
whyrusleeping
force-pushed
the
feat/get-put-cmds
branch
from
0c27ad6 to
4899d93
Compare
Member
Author
|
@jbenet how should I write sharness tests for these? im not if i can bring up multiple nodes in a sharness test... |
Member
Author
|
Also, would like to note that if it werent for the race tests running out of memory, we would have an entirely green test result |
jbenet
added a commit
that referenced
this pull request
Feb 25, 2015
Implement dht put and get CLI commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
ipfs dht getandipfs dht put. Im open to some feedback on this, but this is just part one of a set of changes for getting ipns working well.