docs(security): proces 'Adding a new dependency' + PR template#183
Closed
mpasternak wants to merge 2 commits into
Closed
docs(security): proces 'Adding a new dependency' + PR template#183mpasternak wants to merge 2 commits into
mpasternak wants to merge 2 commits into
Conversation
Praktyka #4 z lirantal/pypi-security-best-practices (Use Deterministic Installations). Audyt wszystkich uv invocations w repo: - CI workflows (tests.yml, refresh-baseline.yml): --frozen present (good) - Dockerfile builder + test stages: --frozen present (good) - Entrypoint scripts: brak uv calls (good - moved to build time per obs 17168) - Makefile prepare-developer-machine-{macos,linux}: BRAK --frozen - dodano w tym commicie (pierwsze setup powinno respektowac lockfile) Wyjatki swiadome (udokumentowane w docs/SECURITY_PRACTICES.md): - make uv-sync (luzny dla aktywnego dev cycle) - make live-docs (sphinx-autobuild celowo poza lockfile) - make enable/disable-microsoft-auth (alternatywa: --extra office365) Nowy plik docs/SECURITY_PRACTICES.md agreguje polityki bezpieczenstwa BPP ze wszystkich PR-ow z serii pypi-security-best-practices: - Deterministyczne instalacje (--frozen) - Wheel-only policy (PR #177) - Cooldown przed instalacja (PR #175, #178) - Eksplicytny indeks PyPI (PR #174) - SHA-pinning GitHub Actions (PR #176) Doc zostanie rozbudowany w PR-ach #10 (secrets) i #11 (dep review).
Praktyki #16, #17 z lirantal/pypi-security-best-practices (Consult Vulnerability Databases / Verify Published Package Contents). docs/SECURITY_PRACTICES.md - nowa sekcja z 5-minutowym checklist dla kazdej nowej Python dep: 1. Vulnerability databases: Snyk Advisor + OSV.dev + GitHub Advisory DB 2. Liveness check: ostatni release, contributors, otwarte issues 3. Trusted Publisher attestation badge na PyPI 4. Reduce dep tree first (praktyka #14): czy stdlib wystarczy? 5. Wheel availability check (uv lock --check --no-build) Sekcja "Verify published wheel content" dla high-risk packages (auth/crypto/network) - krok-po-kroku jak rozpakowac wheel i porownac z tagged source (wykrywa GHA cache poisoning, build-time injection). .github/PULL_REQUEST_TEMPLATE.md - nowy plik z: - Sekcja "Co sie zmienia" + "Plan testowy" - Checklist bezpieczenstwa: nowa dep / sekrety / workflowy / Dockerfile - Sekcja "Powiazane" (issue/ticket) Bazuje na security/deterministic-installs (PR #179).
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Podsumowanie
PR 11/12 z serii pypi-security-best-practices — praktyki #16
(Consult Vulnerability Databases) i #17 (Verify Published Package Contents).
Co się zmienia
docs/SECURITY_PRACTICES.mdNowa sekcja "Adding a new dependency" — 5-minutowy review checklist
dla każdej nowej Python dep:
requests→urllib.request,python-dotenv→ Python 3.13 native.uv lock --check --no-buildmusi przejść.Sub-sekcja "Verify published wheel content" dla high-risk packages
(auth/crypto/network) — krok-po-kroku jak rozpakować wheel i porównać
z tagged source. Wykrywa GHA cache poisoning + build-time injection.
.github/PULL_REQUEST_TEMPLATE.md(NOWY plik)Pierwszy PR template w repo. Sekcje:
.env*→ placeholders only.uv pip installpoza lockfile.Zależności
Bazuje na
security/deterministic-installs(PR #179, tworzydocs/SECURITY_PRACTICES.md). Po jego mergeu rebase czysto.Plan testowy
w opisie (rebase'em).
🤖 Generated with Claude Code