Skip to content

feat: add libp2p command, and identify subcommand - #26

Merged
aschmahmann merged 1 commit into
mainfrom
feat/identify-probe
Jun 21, 2023
Merged

feat: add libp2p command, and identify subcommand#26
aschmahmann merged 1 commit into
mainfrom
feat/identify-probe

Conversation

@aschmahmann

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #26 (d676b00) into main (135d2ac) will decrease coverage by 17.07%.
The diff coverage is 39.65%.

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   38.19%   21.13%   -17.07%     
===========================================
  Files           3        5        +2     
  Lines         233      530      +297     
===========================================
+ Hits           89      112       +23     
- Misses        123      392      +269     
- Partials       21       26        +5     
Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)
lib/identify.go 60.52% <60.52%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aschmahmann
aschmahmann force-pushed the chore/migrate-to-boxo-and-update-deps branch 4 times, most recently from 36b8fa2 to 22ed74b Compare June 21, 2023 06:08
Base automatically changed from chore/migrate-to-boxo-and-update-deps to main June 21, 2023 06:21
@aschmahmann
aschmahmann force-pushed the feat/identify-probe branch from 6584b6a to d676b00 Compare June 21, 2023 06:34
@aschmahmann
aschmahmann force-pushed the feat/identify-probe branch from d676b00 to c5c2525 Compare June 21, 2023 06:53
Comment thread lib/identify.go
@aschmahmann

Copy link
Copy Markdown
Contributor Author

Going to merge as is for now since it seems to do the job and is better than nothing 😄. If people have suggestions please file an issue or better yet a PR 🙏

@aschmahmann
aschmahmann merged commit b05def4 into main Jun 21, 2023
@aschmahmann
aschmahmann deleted the feat/identify-probe branch June 21, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants