test: Take the state test transaction from its encoding - #1614
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves state test execution fidelity by preferring the canonical transaction serialization (txbytes) when available, instead of trusting the decomposed JSON transaction template, enabling detection of additional decoding/encoding failures in state tests.
Changes:
- Added
txbytesstorage to per-case expectations and loaded it from JSON when present. - Updated the state test runner to decode transactions from
txbytes(falling back to the template transaction when not provided) and to reportINVALID_ENCODINGon decode failure. - Introduced
INVALID_ENCODINGas a new transaction error code and added export mapping for it.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/utils/statetest.hpp | Adds txbytes to per-case expectations to carry the canonical serialized transaction bytes. |
| test/utils/statetest_loader.cpp | Loads optional txbytes from JSON into expectations. |
| test/utils/statetest_export.cpp | Maps the new INVALID_ENCODING error to the standardized exported error string. |
| test/statetest/statetest_runner.cpp | Decodes transaction from txbytes when provided; returns INVALID_ENCODING if decoding fails. |
| test/state/errors.hpp | Adds INVALID_ENCODING to the error enum and category messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 97.48% 97.46% -0.03%
==========================================
Files 170 170
Lines 15376 15388 +12
Branches 3591 3596 +5
==========================================
+ Hits 14990 14998 +8
- Misses 281 282 +1
- Partials 105 108 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Comment on lines
+35
to
+37
| tx = state::decode_transaction(*expected.txbytes); | ||
| if (tx.has_value()) | ||
| tx->sender = template_tx.sender; // No recovery yet, take sender from JSON. |
Comment on lines
+40
to
+44
| const auto res = | ||
| tx.has_value() ? | ||
| transition(state, block, test.block_hashes, *tx, rev, vm, block.gas_limit, | ||
| static_cast<int64_t>(state::max_blob_gas_per_block(blob_params))) : | ||
| make_error_code(state::INVALID_ENCODING); |
chfast
force-pushed
the
state/tx-decode-wiring
branch
from
July 27, 2026 07:39
1c514a6 to
7f72262
Compare
chfast
changed the title
A state test's transaction is built from a shared multi-transaction template, which describes the transaction rather than being it: the template cannot express a malformed encoding, so a case whose defect lives in the bytes was executed as if it were well formed. In execution-specs tests@v20.0.1 that is the whole frontier/validation/bad_v_r_s family, 116 cases the runner reported as "unexpected valid transaction". Each post entry carries the serialization it was built from as "txbytes". Decode it and run that transaction instead; input that does not decode makes the transaction invalid (INVALID_ENCODING). The sender still comes from the template, so nothing about the signature is verified yet.
chfast
force-pushed
the
state/tx-decode-wiring
branch
from
July 27, 2026 07:53
7f72262 to
57e3d53
Compare
chfast
added a commit
that referenced
this pull request
Aug 9, 2026
The state test runner still took the sender from the fixture's template, so a signature was only ever checked for shape. The remaining frontier/validation/bad_v_r_s cases are legacy transactions that decode cleanly and carry an out-of-range r or s; nothing rejected them. Add state::recover_sender() and use it, as a node does; a signature that does not recover makes the transaction invalid (INVALID_SIGNATURE). Recovery is strict, so EIP-2 low-s and r, s in [1, secp256k1n) come from ecrecover itself. The signing preimage is a slice of the serialization -- the payload without the trailing (v, r, s), and for a protected legacy transaction (chain_id, 0, 0) in their place -- so recover_sender() takes the decoded transaction together with the bytes it came from, and finds the end of the signed prefix by subtracting the sizes of the canonically encoded signature fields. Reusing the slice avoids restating every transaction type's field order next to rlp_encode(), which already states it. The exported "expectException" name is added for the new code as well; EEST names encoding failures one by one, so INVALID_ENCODING, minted by the same runner path since #1614, gets its plain message instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load test transaction from its encoding in
"txbytes"instead of trusting the decomposed JSON variant.This detected some additional expect decoding failures in tests.
We still lack sender address recovery from signatures, so take it as previously from JSON
"sender".