Use (optional) reduced OSPF timers in BGP integration tests#3303
Merged
Conversation
This change tries to use the short OSPF timers in BGP integration tests (guarded with _adjust entry that checks the device capability) and can reduce the runtime of an integration test by ~10 seconds.
There was a problem hiding this comment.
Pull request overview
This PR reduces runtime of several BGP integration tests by configuring shorter OSPF hello/dead timers, while keeping compatibility by conditionally removing the timer settings on devices that don’t support ospf.timers via the existing _adjust mechanism.
Changes:
- Extend
adjust_testplugin removal logic to supportobject:itemsyntax (e.g.nodes:ospf.timers) for removing a nested key from all items in a topology subsection. - Update multiple BGP integration topology YAMLs to:
- load
adjust_testfrom the test plugin path, and - set reduced
ospf.timers.{hello,dead}with an_adjuststanza that removes timers when unsupported.
- load
- Move
defaults.bgp.astobgp.asin the updated test topologies.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/plugin/adjust_test.py | Adds object:item removal support to delete a nested key across all entries (used for nodes:ospf.timers). |
| tests/integration/bgp/02-ibgp-ebgp-session.yml | Enables adjust_test, sets reduced OSPF timers, removes timers when unsupported. |
| tests/integration/bgp/03-ibgp-rr.yml | Enables adjust_test, sets reduced OSPF timers, removes timers when unsupported. |
| tests/integration/bgp/04-originate.yml | Sets reduced OSPF timers and adds conditional removal for unsupported devices. |
| tests/integration/bgp/05-community.yml | Enables adjust_test alongside files, sets reduced OSPF timers, removes timers when unsupported. |
| tests/integration/bgp/08-ibgp-localas.yml | Enables adjust_test, sets reduced OSPF timers, removes timers when unsupported. |
Copilot AI
added a commit
that referenced
this pull request
Apr 9, 2026
…attern Agent-Logs-Url: https://github.com/ipspace/netlab/sessions/48c8af87-52de-4845-84d4-08c163ed81c9 Co-authored-by: ipspace <16917911+ipspace@users.noreply.github.com>
ipspace
pushed a commit
that referenced
this pull request
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change tries to use the short OSPF timers in BGP integration tests (guarded with _adjust entry that checks the device capability) and can reduce the runtime of an integration test by ~10 seconds.