Add reduced OSPF timers to remaining BGP integration tests#3304
Merged
Conversation
…attern Agent-Logs-Url: https://github.com/ipspace/netlab/sessions/48c8af87-52de-4845-84d4-08c163ed81c9 Co-authored-by: ipspace <16917911+ipspace@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ipspace
April 9, 2026 10:34
View session
ipspace
added a commit
that referenced
this pull request
Apr 9, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the remaining BGP integration test topologies that run OSPF to use reduced OSPF hello/dead timers (1/3 seconds) to speed up convergence, following the established pattern from PR #3303. The change is gated with the adjust_test plugin so devices lacking the ospf.timers feature have the per-node timers removed.
Changes:
- Add
defaults.paths.prepend.pluginandadjust_testplugin where needed so tests can conditionally remove unsupported attributes. - Set topology-level
ospf.timers.hello: 1andospf.timers.dead: 3across the remaining OSPF-using BGP tests. - Add
_adjustblocks to removenodes:ospf.timerswhen the DUT (or relevant node) lacksfeatures: [ ospf.timers ].
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/bgp/bgp.domain.yml | Enable reduced OSPF timers and gate them with adjust_test for unsupported devices. |
| tests/integration/bgp/31-import-policy.yml | Add reduced OSPF timers + _adjust gating; add plugin path + adjust_test. |
| tests/integration/bgp/30-import-ds-ospf.yml | Add adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp/20-dual-stack-activate.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp/14-ipv6-originate.yml | Add reduced OSPF timers and feature-gated removal. |
| tests/integration/bgp/13-ipv6-ibgp-rr.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp/12-ipv6-ibgp-ebgp.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/51-weight.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/22-locpref-unnumbered.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/21-locpref.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/12-bgp-bandwidth-value-out.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/11-bgp-bandwidth-value.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.policy/10-bgp-bandwidth-auto.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.multihop/x-03-localas_ibgp.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.multihop/x-01-global-ipv4.yml | Add plugin path + adjust_test, reduced OSPF timers, and feature-gated removal. |
| tests/integration/bgp.multihop/02-vrf.yml | Add reduced OSPF timers and feature-gated removal. |
| tests/integration/bgp.multihop/01-global.yml | Add reduced OSPF timers and feature-gated removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR #3303 as a template, this PR adds reduced OSPF timers (
ospf.timers.hello: 1,ospf.timers.dead: 3) to all remaining BGP integration tests that use OSPF (where ospf appears in the topology or node module list).The pattern applied to each file:
defaults.paths.prepend.plugin: [ "topology:../plugin" ](where not already present)adjust_testto the plugin list (where not already present)ospf.timers.hello: 1andospf.timers.dead: 3at topology level_adjustentry that removesnodes:ospf.timersfor devices that don't support theospf.timersfeatureFiles changed:
bgp.multihop/01-global.ymlbgp.multihop/02-vrf.ymlbgp.multihop/x-01-global-ipv4.ymlbgp.multihop/x-03-localas_ibgp.ymlbgp.policy/10-bgp-bandwidth-auto.ymlbgp.policy/11-bgp-bandwidth-value.ymlbgp.policy/12-bgp-bandwidth-value-out.ymlbgp.policy/21-locpref.ymlbgp.policy/22-locpref-unnumbered.ymlbgp.policy/51-weight.ymlbgp/12-ipv6-ibgp-ebgp.ymlbgp/13-ipv6-ibgp-rr.ymlbgp/14-ipv6-originate.ymlbgp/20-dual-stack-activate.ymlbgp/30-import-ds-ospf.ymlbgp/31-import-policy.ymlbgp/bgp.domain.yml