SR Linux: Fix LDP configuration template#3414
Merged
Merged
Conversation
Owner
ipspace
commented
May 19, 2026
ipspace
commented
- Use correct interface name syntax and enable LDP for IPv4 in the 'protocols/ldp/discovery' block (the major showstopper)
- Merge LDP configuration blocks into a single block
- Enable MPLS ICMP tunneling
- Allocate more labels to the LDP pool and change its name to 'ldp'
- Remove the template checks for device type (that's done in device quirks)
* Use correct interface name syntax and enable LDP for IPv4 in the 'protocols/ldp/discovery' block (the major showstopper) * Merge LDP configuration blocks into a single block * Enable MPLS ICMP tunneling * Allocate more labels to the LDP pool and change its name to 'ldp' * Remove the template checks for device type (that's done in device quirks)
ipspace
added a commit
that referenced
this pull request
May 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes and refactors the SR Linux LDP MPLS configuration template to generate correct SR Linux JSON-RPC/YAML updates, including proper LDP discovery/interface handling and updated label-range/MPLS settings.
Changes:
- Refactors SR Linux LDP config into a single consolidated update block and fixes LDP discovery interface rendering (including enabling IPv4 per interface).
- Updates MPLS settings: enables ICMP tunneling, renames/expands the LDP label range pool, and aligns SR Linux update keys (
value) and paths. - Removes in-template device-type gating, relying on SR Linux device quirks instead.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| netsim/ansible/templates/mpls/srlinux.ldp.j2 | Reworks SR Linux LDP updates (label pool, MPLS ICMP tunneling, consolidated LDP + discovery interface config). |
| netsim/ansible/templates/mpls/srlinux.j2 | Adds the updates: wrapper for the SR Linux MPLS template and includes the LDP fragment conditionally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.