Fix: Null update/delete values become empty lists in SR Linux config#3415
Merged
Conversation
As a safeguard against 'updates:' (or some such) lists generated by the Jinja2 templates becoming "null", the 'default([])' filter used to set the Ansible module parameters now converts falsy values into empty lists
There was a problem hiding this comment.
Pull request overview
This PR hardens the SR Linux deploy-config Ansible task against YAML config fragments where delete:, updates:, or replace: are present but evaluate to null, ensuring the Nokia SR Linux Ansible module receives empty lists instead of null.
Changes:
- Treat
cfg.delete,cfg.updates, andcfg.replaceas empty lists when they are falsy (includingnull) by switching todefault([], true). - Preserve existing task execution gating (
when:) while preventing null list parameters from reachingnokia.srlinux.config.
ipspace
added a commit
that referenced
this pull request
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a safeguard against 'updates:' (or some such) lists generated by the Jinja2 templates becoming "null", the 'default([])' filter used to set the Ansible module parameters now converts falsy values into empty lists.
Based on a review comment in #3414