get documentation building#3
get documentation building#3justinkao wants to merge 3 commits intoipython:masterfrom justinkao:docs
Conversation
ipython_parallel/_version.py
Outdated
There was a problem hiding this comment.
Can you revert the changes in _version_.py, please and leave it how it was? It was like that for a reason.
There was a problem hiding this comment.
The conf script for ipython uses _version_extra to insert a disclaimer:
https://github.com/ipython/ipython/blob/master/docs/source/conf.py#L72
I wanted to also support this, should I take it out?
There was a problem hiding this comment.
See what we did for nbconvert - left it basically the same but added _version_extra:
https://github.com/jupyter/jupyter_nbconvert/pull/1/files#diff-d7781741d938b7b8e52a1059d3772880
There was a problem hiding this comment.
I would indeed take out the check for version_extra in conf.py and leave _version.py exactly how it is.
docs/source/conf.py
Outdated
There was a problem hiding this comment.
This can be replaced with _version.version_info[-1] == 'dev'. There is no need for any changes in _version.py
let's not inherit any style or templates from IPython. That stuff is super old. |
|
@justinkao are you planning to address comments on this, or should we finish it up? |
|
Finished up in #5 |
3 participants
_version.pyto contain more version infoexamples/Parallel Computingdown intoexamples/and update linksdocs/source/paralleldown intodocs/sourcemakein thedocs/directory now generates html output