Catch interrupted poll() in terminal console#8129
Merged
minrk merged 1 commit intoipython:masterfrom Mar 24, 2015
Merged
Conversation
Alternative to my own PR ipython#8108 - catch ZMQError in run_cell, and if it's caused by an interrupt, ignore it. more complex, especially if we want to handle the timeout nicely as proposed in the comments, but it's possibly also more convenient for other users of that API. Or perhaps not - I'm not sure what makes sense for other API consumers in this case. Fixes ipythongh-8105
Member
|
I think this will misbehave if you do: try:
time.sleep(10)
except KeyboardInterrupt:
print("interrupted")
foo = input('foo> ')and interrupt the sleep. |
Member
|
Nope, totally wrong. I missed the |
Member
|
I think this should work. It's definitely nice to not need the deadline handling. |
minrk
added a commit
that referenced
this pull request
Mar 24, 2015
Catch interrupted poll() in terminal console
minrk
added a commit
that referenced
this pull request
Mar 25, 2015
Alternative to my own PR #8108 - catch ZMQError in run_cell, and if it's caused by an interrupt, ignore it. #8108 catches the exception in the blocking kernel client API, which is more complex, especially if we want to handle the timeout nicely as proposed in the comments, but it's possibly also more convenient for other users of that API. Or perhaps not - I'm not sure what makes sense for other API consumers in this case. Fixes gh-8105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to my own PR #8108 - catch ZMQError in run_cell, and if it's caused by an interrupt, ignore it.
#8108 catches the exception in the blocking kernel client API, which is more complex, especially if we want to handle the timeout nicely as proposed in the comments, but it's possibly also more convenient for other users of that API. Or perhaps not - I'm not sure what makes sense for other API consumers in this case.
Fixes gh-8105